Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go-control-plane envoy dependency to 0.12.0 #20973

Merged
merged 5 commits into from
Apr 10, 2024
Merged

update go-control-plane envoy dependency to 0.12.0 #20973

merged 5 commits into from
Apr 10, 2024

Conversation

jmurret
Copy link
Member

@jmurret jmurret commented Apr 9, 2024

Replaces #20957 since we need to update a few more places and the CLA signing is currently blocked there.

Description

Updates the dependency that provides some of Envoy's config schemas.

The reason for this is mainly to get the spawn_upstream_span option, introduced 0.12.0.

Without this update, trying to set this field in a proxy.config's envoy_listener_tracing_json results in an error like:

agent.envoy.xds: failed to parse ListenerTracingJSON config: (...) xdsVersion=v3 error="proto: (line 1:546): unknown field \"spawn_upstream_span\""

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@jmurret jmurret added pr/dependencies PR specifically updates dependencies of project pr/no-backport labels Apr 9, 2024
@jmurret jmurret requested a review from david-yu April 9, 2024 22:52
david-yu
david-yu approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@david-yu david-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming tests pass.

@jmurret jmurret mentioned this pull request Apr 9, 2024
Closed
4 tasks
@jmurret jmurret enabled auto-merge (squash) April 10, 2024 01:19
@jmurret jmurret merged commit d261a98 into main Apr 10, 2024
85 checks passed
@jmurret jmurret deleted the jm/go-control-plane0.12.0 branch April 10, 2024 01:23
Cottand pushed a commit to Cottand/consul that referenced this pull request May 25, 2024
@jmurret @Cottand
update go-control-plane envoy dependency to 0.12.0 (hashicorp#20973)
ff7a1f2 
* update go-control-plane envoy dependency to 0.12.0

* add changelog

* go mod tidy

* fix linting issues

* add agent/grpc-internal to the list of SA1019 ignores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-yu david-yu david-yu approved these changes

Assignees
No one assigned
Labels
pr/dependencies PR specifically updates dependencies of project pr/no-backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmurret @david-yu