Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] codemirror lint removal #21726

Merged
merged 4 commits into from
Sep 13, 2024
Merged

[ui] codemirror lint removal #21726

merged 4 commits into from
Sep 13, 2024

Conversation

philrenaud
Copy link
Collaborator

Do-over of #21724

This removes the JSON Linting gutter highlight capabilities.

The main reason for this removal is the inclusion of a nested Underscore dependency: https://github.com/hashicorp/consul/security/dependabot/6

@philrenaud philrenaud added the backport/all Apply backports for all active releases per .release/versions.hcl label Sep 13, 2024
@philrenaud philrenaud self-assigned this Sep 13, 2024
@github-actions github-actions bot added the theme/ui Anything related to the UI label Sep 13, 2024
dduzgun-security
dduzgun-security approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@dduzgun-security dduzgun-security left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@philrenaud philrenaud merged commit de281cb into main Sep 13, 2024
60 checks passed
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.19 This release series is longer active on CE, use backport/ent/1.19 backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent labels Sep 13, 2024
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Sep 13, 2024
Merged
@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

4 similar comments
@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@jmurret jmurret added backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.18 Changes are backported to 1.18 ent and removed backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.18 Changes are backported to 1.18 ent labels Sep 18, 2024
@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

4 similar comments
@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

1 similar comment
@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@dhiaayachi dhiaayachi mentioned this pull request Sep 25, 2024
Open
@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

22 similar comments
@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Contributor

📣 Hi @philrenaud! a backport is missing for this PR [21726] for versions [1.17,1.18] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@philrenaud
Copy link
Collaborator Author

philrenaud commented Oct 15, 2024 •
edited
Loading

Backports merged: 1.18.x enterprise and 1.17.x enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduzgun-security dduzgun-security dduzgun-security approved these changes

@sarahalsmiller sarahalsmiller Awaiting requested review from sarahalsmiller

Assignees

@philrenaud philrenaud

Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.17 This release series is longer active on CE or Ent backport/ent/1.18 Changes are backported to 1.18 ent backport/1.19 This release series is longer active on CE, use backport/ent/1.19 theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philrenaud @hc-github-team-consul-core @dduzgun-security @jmurret