Integrates Consul with "stage one" of HashiCorp Raft library v2. #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackpad
force-pushed
the
f-raft-v2
branch
4 times, most recently
from
660adb8 to
8dd1207
Compare
|
The dependent changes have been pulled into the https://github.com/hashicorp/raft/tree/library-v2-stage-one branch over in Raft, which will serve as our stable branch for Consul as other Raft refactoring takes place. These changes are now vendored so this is ready for review. |
slackpad
changed the title
|
Switched to govendor so rebase incoming to fix up the metadata. |
This isn't safe because it would implicitly commit all outstanding log entries. The new Raft library already has logic to not start a vote if the current node isn't in the configuration, so this shoudn't be needed.
| if err := s.raft.SetPeers(addrs).Error(); err != nil { | ||
| s.logger.Printf("[ERR] consul: failed to bootstrap peers: %v", err) | ||
| // Attempt a live bootstrap! | ||
| s.logger.Printf("[INFO] consul: found expected number of peers, attempting to bootstrap cluster...") |
There was a problem hiding this comment.
I think its useful to have it log the IPs it is attempting to bootstrap with as a sanity check
There was a problem hiding this comment.
Good call - I'll add them to this log message.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't ready to merge until we do the proper vendoring but the integration part is ready for review. All unit tests are passing locally and I've booted a test cluster with this :-)