Adds ACL replication. #2237
Merged
Adds ACL replication. #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't ready for review but I'm pushing this up as a checkpoint as the basic plumbing is working. |
slackpad
force-pushed
the
f-acl-replication
branch
4 times, most recently
from
3caa4c8
to
f0a04bc
Compare
slackpad
force-pushed
the
f-acl-replication
branch
from
f0a04bc
to
096d5ff
Compare
Decided we don't need to log anything about the token here. If the token is not valid then the client will get an error about that, so anything that can happen here is related to talking to the server in the ACL datacenter, so not specific to the token.
|
Ready for review! |
We don't want ACL replication to have this behavior so it was a little dangerous to have in the shared helper function.
| @@ -37,24 +37,29 @@ const ( | |||
| redactedToken = "<hidden>" | |||
|
|
|||
| // Maximum number of cached ACL entries | |||
| aclCacheSize = 256 | |||
| aclCacheSize = 10 * 1024 | |||
There was a problem hiding this comment.
Can we use this chance to switch from the LRU cache to 2Q? It's in the same package!
There was a problem hiding this comment.
Ah good call - I'll roll that in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1419 by providing a full replication capability for ACLs. Non-ACL datacenters can replicate the complete ACL set locally to their state store and fall back to that if there's an outage, if so configured. Additionally, this provides a good way to make a backup ACL datacenter, or to migrate the ACL datacenter to a different one. This'll fix #1826 and should also mention #1186.