-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BindAddr may be "::" without "[]" (supported) #2285
Conversation
@sean- can you plz. look at this one wrt. to go-sockaddr? |
Consul doesn't need to use square brackets when establishing an IPv6 default address. We could/should make this change, but I'd suggest we align this with the other non-BC changes for 0.8. We could/should also interpret
The issue is if you don't specify an advertise address, Consul dies because you can't advertise an endpoint that's the IPv6 equiv of I'm also pretty indifferent, but would guess given AWS's announcement re: IPv6 today, I think this is going to be a more common source of toe-stubbing in the near future. The question is, how far do we want to go in terms of fixing this? I think we do it right, but that involves some non-BC changes. TL;DR: |
@magiconair None, go for it. |
(alternative is to not allow
-bind ::
)Using
::
and[::]
is practically equivalent (https://www.ietf.org/rfc/rfc2732.txt) depending on some context.