Adds performance tuning capability for Raft, detuned defaults, and supplemental docs. #2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackpad
force-pushed
the
f-tunes
branch
3 times, most recently
from
a95ad5a to
9c8c848
Compare
Rather than scale this we just bump it up a bit. It'll be on the edge in the lower-performance default mode, and will have plenty of margin in the high-performance mode. This seems like a reasonable compromise to keep the logic here simple vs. scaling, and seems inline with the expectations of the different modes of operation.
| def := raft.DefaultConfig() | ||
| c.RaftConfig.HeartbeatTimeout = raftMult * def.HeartbeatTimeout | ||
| c.RaftConfig.ElectionTimeout = raftMult * def.ElectionTimeout | ||
| c.RaftConfig.CommitTimeout = raftMult * def.CommitTimeout |
There was a problem hiding this comment.
Do we want to scale this? This won't affect stability but affects the commit tail latency on followers
There was a problem hiding this comment.
Oh good catch - I'll remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale for this one is explained in the new server performance guide that's part of this PR.