Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable timeout for the recursor's dns client #2321

Closed
wants to merge 7 commits into from
Closed

Configurable timeout for the recursor's dns client #2321

wants to merge 7 commits into from

Conversation

pdelagrave
Copy link

@pdelagrave pdelagrave commented Sep 1, 2016 •
edited
Loading

Includes tests for the new config parameter and the timeout

As discussed here: #2309

@pdelagrave
Copy link
Author 

--- FAIL: TestTombstoneGC (0.03s)
    tombstone_gc_test.go:71: bad index: 120
FAIL
coverage: 86.9% of statements
FAIL    github.com/hashicorp/consul/consul/state    0.778s

This does not seem to be related to the changes proposed in this PR

@slackpad slackpad mentioned this pull request Sep 2, 2016
Merged
@slackpad
Copy link
Contributor

slackpad commented Sep 2, 2016

Hi @Pivotal-Pierre-Delagrave thanks for the PR! Looks great and I merged this under #2322 with just a couple tweaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdelagrave @slackpad