Disable -bootstrap-expect flag in dev mode #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackpad
reviewed
Nov 3, 2016
| @@ -271,6 +271,12 @@ func (c *Command) readConfig() *Config { | |||
| return nil | |||
| } | |||
|
|
|||
| // Expect can only work when dev mode is off | |||
| if config.BootstrapExpect > 0 && config.DevMode { | |||
| c.Ui.Error("WARNING: Expect mode cannot be enabled when dev mode is enabled") | |||
There was a problem hiding this comment.
Should drop the "WARNING:" on here, since it's an error, but otherwise LGTM.
slackpad
suggested changes
Nov 3, 2016
kyhavlov
force-pushed
the
b-dev-expect-panic
branch
from
54afc55 to
87d8eff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the panic described here #2428 (comment) when both -dev and -bootstrap-expect are provided. Expect mode won't do anything in dev mode even with the crash fixed, so it seemed best to just disallow this and provide an error message.