Set MaxStale default to 10 years and add a stale counter #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a counter at `consul.dns.stale_queries` that tracks when an agent serves a query that's stale by at least 5 seconds. Fixes #2460.
|
Just need to update the configuration doc and should be good to go. This'll also need a note in the version-specific upgrade docs. |
slackpad
reviewed
Nov 8, 2016
| * <a name="max_stale"></a><a href="#max_stale">`max_stale`</a> - When [`allow_stale`](#allow_stale) | ||
| is specified, this is used to limit how stale results are allowed to be. If a Consul server is | ||
| behind the leader by more than `max_stale`, the query will be re-evaluated on the leader to get | ||
| more up-to-date results. By default, this is set to 10 years ("87600h") which effectively allows |
There was a problem hiding this comment.
This'll need a "prior to Consul 0.7.1 this was 5s, in Consul 0.7.1 and later this is ..." so the docs are compatible with current versions.
slackpad
reviewed
Nov 8, 2016
| @@ -178,6 +178,12 @@ These metrics give insight into the health of the cluster as a whole. | |||
| <td>timer</td> | |||
| </tr> | |||
| <tr> | |||
| <td>`consul.dns.stale_queries`</td> | |||
| <td>This increments when an agent serves a DNS query based on information from a server that is more than 5 seconds out of date.</td> | |||
There was a problem hiding this comment.
This should get a note that it was added in Consul 0.7.1.
slackpad
suggested changes
Nov 8, 2016
slackpad
approved these changes
Nov 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a counter at
consul.dns.stale_queriesthat tracks when an agentserves a query that's stale by at least 5 seconds.
Fixes #2460.