cli: Add KV export and import
#2633
Conversation
jen20
force-pushed
the
kv-export-import
branch
from
b1ef59b to
44bba65
Compare
|
|
||
| ` + apiOptsText + ` | ||
|
|
||
| KV Get Options: |
There was a problem hiding this comment.
Should say KV Export Options:
| @@ -81,7 +81,7 @@ KV Get Options: | |||
|
|
|||
| func (c *KVGetCommand) Run(args []string) int { | |||
| cmdFlags := flag.NewFlagSet("get", flag.ContinueOnError) | |||
| cmdFlags.Usage = func() { c.Ui.Output(c.Help()) } | |||
There was a problem hiding this comment.
This looks like an unrelated change, but if this is implied by not setting .Usage then makes sense and is fine.
|
|
||
| ` + apiOptsText + ` | ||
|
|
||
| KV Get Options: |
|
|
||
| Or it can be read from stdin using the "-" symbol: | ||
|
|
||
| $ cat filename.json | consul kv put config/program/license - |
|
|
||
| data := args[0] | ||
|
|
||
| switch data[0] { |
There was a problem hiding this comment.
Will this crash if you pass an empty quoted string in as the first arg?
There was a problem hiding this comment.
Likely yes - this is copied from kv put so that probably has the same behaviour. I'll update.
| if strings.TrimSpace(string(pair.Value)) != "bar" { | ||
| t.Fatalf("bad: expected: bar, got %s", pair.Value) | ||
| } | ||
| } |
There was a problem hiding this comment.
Might as well check foo/a as well.
| @@ -81,7 +81,7 @@ KV Get Options: | |||
|
|
|||
| func (c *KVGetCommand) Run(args []string) int { | |||
| cmdFlags := flag.NewFlagSet("get", flag.ContinueOnError) | |||
| cmdFlags.Usage = func() { c.Ui.Output(c.Help()) } | |||
There was a problem hiding this comment.
Is this intended? Maybe I missed it but I didn't see this move elsewhere.
jen20
force-pushed
the
kv-export-import
branch
4 times, most recently
from
69fe814 to
f26d387
Compare
|
I've fixed up most of the review comments, probably also need to look at |
|
Latest changes look good to merge. I think it's fine if you want to fix the empty arg issue here for |
This commit adds two new commands to the Consul KV CLI, which export and import a JSON formatted representation of the Consul KV tree. It is useful to migrate parts of the KV tree between unrelated Consul clusters, and could also be used for initial data population of the KV store.
jen20
force-pushed
the
kv-export-import
branch
from
f26d387 to
d4e8c8a
Compare
This commit adds two new commands to the Consul KV CLI, which export and import a JSON formatted representation of the Consul KV tree. It is useful to migrate parts of the KV tree between unrelated Consul clusters, and could also be used for initial data population of the KV store.