Add node metadata filtering to remaining endpoints #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled multiple meta filters for /v1/catalog/nodes and /v1/catalog/services
slackpad
approved these changes
Jan 15, 2017
|
|
||
| for _, tc := range cases { | ||
| var out structs.IndexedHealthChecks | ||
| inState := structs.ServiceSpecificRequest{ |
| @@ -287,6 +289,15 @@ type Node struct { | |||
| } | |||
| type Nodes []*Node | |||
|
|
|||
| func SatisfiesMetaFilters(meta map[string]string, filters map[string]string) bool { | |||
There was a problem hiding this comment.
Should add a comment for this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for filtering by node metadata values to the following endpoints:
It also updates /v1/catalog/nodes and /v1/catalog/services to support multiple metadata filters.