Add JSON validation to UI #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jackturnbull Could you please rebase this? |
JSON validation added to UI. This has been implemented through the use of a flag to enable/disable the functionality with a watcher on the value to set the success/error class on the textarea itself. No hard validation added to the field.
JSON validation has now been added to the update view following the same format as create. Since 'valueDecoded' does not have the ability to check if the value is base64 before decoding then this must be checked first; if it is base64 then use the decoded one, if not just get the value. Change incorrect trailing span close to label.
|
@sethvargo All done 😄 |
|
Thanks! |
slackpad
added a commit
that referenced
this pull request
May 2, 2017
johncowen
pushed a commit
that referenced
this pull request
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd expect that there'd be other users than ourselves that use the Key/Value store to store JSON nested keys so I thought I'd pass up a PR for review. The implementation itself is pretty lightweight; see if
JSON.parsethrows an error, if not then valid. TheisValidfunction can be changed to suit.This has been implemented through the use of a flag to enable/disable the functionality with a watcher on the value to set the success/error class on the textarea itself:
Default
Enabled (error)
Enabled (success)
No hard validation added to form to prevent the request - intentional as this didn't feel like expected behaviour and I didn't want to force the users into any specific workflow.
In all honesty, I won't be heartbroken if this doesn't make it in, we can run our own UI after all although I do think its a net gain overall. cc: @nathanhebe