Adds support for WAN soft fail and join flooding. #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackpad
force-pushed
the
spoken-hub-oss
branch
from
c2e0469 to
2f49089
Compare
This has the next wave of RTT integration with the router and also factors some common RTT-related helpers out to lib. While we were in here we also got rid of the coordinate disable config so we don't need to deal with the complexity in the router (there was never a user-visible way to disable coordinates).
slackpad
force-pushed
the
spoken-hub-oss
branch
from
5788263 to
79e192f
Compare
|
Should be in good shape for a review. |
kyhavlov
approved these changes
Mar 20, 2017
api/operator_area.go
Outdated
| // when creating a new area. | ||
| ID string | ||
|
|
||
| // PeeerDatacenter is the peer Consul datacenter that will make up the |
There was a problem hiding this comment.
typo, should be PeerDatacenter
api/operator_area.go
Outdated
| Joined bool | ||
|
|
||
| // If we couldn't join, this is the message with information. | ||
| What string |
There was a problem hiding this comment.
Could this just be called Error?
There was a problem hiding this comment.
Yeah that's probably better - that was a C++ carryover.
api/operator_area.go
Outdated
| // PeeerDatacenter is the peer Consul datacenter that will make up the | ||
| // other side of this network area. Network areas always involve a pair | ||
| // of datacenters: the datacenter where the area was created, and the | ||
| // peer datacenter. This is required |
| return false, nil | ||
| raft_vsn := 0 | ||
| raft_vsn_str, ok := m.Tags["raft_vsn"] | ||
| if ok { |
There was a problem hiding this comment.
Good catch with this, I wouldn't have realized to do this until testing alongside an older consul binary
consul/server_test.go
Outdated
| return len(s3.WANMembers()) == 3, nil | ||
| }, func(err error) { | ||
| t.Fatalf("bad len") | ||
| }) |
There was a problem hiding this comment.
Could this section be shortened to:
for i, s := range []*Server{s1, s2, s3} {
testutil.WaitForResult(func() (bool, error) {
return len(s.WANMembers()) == 3, nil
}, func(err error) {
t.Fatalf("bad len for server %d", i)
})
}
This was referenced Apr 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAN Soft Fail
This makes request routing between servers in the WAN more robust by treating Serf failures as advisory but not final. This means that if servers are having issues between some subset of the servers in the WAN, we will still be able to route RPC requests as long as RPCs are actually still working. Prior to WAN soft fail, any DCs having connectivity problems on the WAN would mean that all DCs might potentially stop sending RPCs to those DCs.
WAN Join Flooding
We added a routine that looks for Consul servers in the LAN and makes sure that they are joined into the WAN as well. This catches up up newly-added servers onto the WAN as soon as they join the LAN.