Fix ipv6 join failure on upgrade 0.7.2 to 0.8 #2878
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're running an IPv6-only cluster.
With upgrade from 0.7.2 to 0.8 we got
dial tcp: too many colons in address
on startupThis PR fixes this by adding brackets in serf_flooder when the address is an IPv6 address (and no port has been added by net.JoinHostPort (which adds the brackets correctly))
This way, the
hasPort
function (see https://github.com/hashicorp/consul/blob/master/vendor/github.com/hashicorp/memberlist/util.go#L220-L232) works correctly when called byresolveAddr
(https://github.com/hashicorp/consul/blob/master/vendor/github.com/hashicorp/memberlist/memberlist.go#L277)