UI: open docs links in new tab #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set `target="_blank"` on all docs URLs
|
This is a good fix! Can you please update all the links to https://www.consul.io/docs/guides/acl.html as well (the old internals page is now obsolete)? |
|
Good idea and will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target="_blank"on all docs URLs linked from within UIThis is helpful because if a user clicks the docs link from UI and has already entered any details into a form, say when creating a new ACL, they will be brought to the docs in the same window as the UI, and will lose everything they've entered into the form when clicking the back button:
This can be a frustrating thing from a UX perspective, so this change mitigates that by opening all docs links from the UI in a new tab/window.