Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service maintenance mode #345

Closed
armon opened this issue Sep 16, 2014 · 1 comment
Closed

Service maintenance mode #345

armon opened this issue Sep 16, 2014 · 1 comment
Labels
type/enhancement Proposed improvement or new feature

Comments

@armon
Copy link
Member

armon commented Sep 16, 2014

Support a simple mechanism to flip a service into a maintenance mode to prevent routing traffic. Likely this is just an agent API which maps to a temporary health check set to the "critical" state with the relevant notes attached. We can even support a TTL mechanism to flip out of maintenance mode to protect against a buggy client that leaves this mode on.

@armon armon added the type/enhancement Proposed improvement or new feature label Sep 16, 2014
@ryanuber
Copy link
Member

Done in #606! We don't support a TTL mechanism yet, so it's currently possible for a buggy client to leave maintenance mode enabled. If we introduce a TTL, I could also see needing to have the ability to remove the TTL while maintenance mode was still enabled in case things go wrong, or updating the TTL to extend it. Not sure if that would be helpful or confusing to a user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests

2 participants