Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Args array erroneously set to ScriptArgs in /v1/agent APIs #3587

Closed
slackpad opened this issue Oct 18, 2017 · 1 comment
Closed

Args array erroneously set to ScriptArgs in /v1/agent APIs #3587

slackpad opened this issue Oct 18, 2017 · 1 comment
Assignees
Labels
theme/health-checks Health Check functionality type/bug Feature does not function as expected
Milestone

Comments

@slackpad
Copy link
Contributor

This captures an issue from from https://groups.google.com/d/msgid/consul-tool/9dca61e6-26b0-4315-a891-2713756f768a%40googlegroups.com?utm_medium=email&utm_source=footer.

It looks like we didn't JSON-annotate fields correctly, so Args ended up as ScriptArgs in the /v1/agent check and service registration APIs. We also left the Args field out of the API client. We need to add this to the API client and fix up the documentation so it works with what we shipped.

We should rename the field Args so that the config file syntax matches the JSON in the API, but we will need to retain backwards compatibility with ScriptArgs since that has already shipped.

@slackpad slackpad added type/bug Feature does not function as expected theme/health-checks Health Check functionality labels Oct 18, 2017
@slackpad slackpad added this to the 1.0.1 milestone Oct 18, 2017
@slackpad slackpad self-assigned this Oct 18, 2017
@slackpad
Copy link
Contributor Author

This is another issue related to #3179.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/health-checks Health Check functionality type/bug Feature does not function as expected
Projects
None yet
Development

No branches or pull requests

1 participant