Allow to control the number of A/AAAA Record returned by DNS #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to have randomized resource records (i.e. each answer contains only one IP, but the IP changes every request) for A, AAAA records. It will fix hashicorp#3355 and hashicorp#3937 See hashicorp#3937 (comment) for details. It basically add a new option called `a_record_limit` and will not return more than a_record_limit when performing A, AAAA or ANY DNS requests. The existing `udp_answer_limit` option is still working but should be considered as deprecated since it works only with DNS clients not supporting EDNS.
preetapan
reviewed
Mar 7, 2018
agent/dns_test.go
Outdated
| @@ -2997,6 +2997,163 @@ func testDNSServiceLookupResponseLimits(t *testing.T, answerLimit int, qType uin | |||
| return true, nil | |||
| } | |||
|
|
|||
| func testDNSServiceLookupResponseARecordLimits(t *testing.T, generateNumNodes int, aRecordLimit int, qType uint16, | |||
There was a problem hiding this comment.
Can just have this return an error instead of both an error and bool, and check whether an error occurred.
Also, can you rename this to checkDNSService...
There was a problem hiding this comment.
@preetapan DONE in next patch
preetapan
reviewed
Mar 7, 2018
|
Could you also add documentation for the new option to https://www.consul.io/docs/agent/options.html#dns_config |
|
@preetapan DONE in the next patch! |
|
After this PR, you might have a look on #3948 which solves also issues on large clusters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to have randomized resource records (i.e. each answer contains only one IP, but the IP changes every request) for A, AAAA records.
It will fix #3355 and #3937
See #3937 (comment) for details.
It basically add a new option called
a_record_limitand will not return more than a_record_limit when performing A, AAAA or ANY DNS requests.The existing
udp_answer_limitoption is still working but should be considered as deprecated since it works only with DNS clients not supporting EDNS.