NodeMeta Data is not stored in snapshots

[nickmy9729]

When issuing command consul snapshot save /somedir/filename.snap. The snapshot produced does not contain the NodeMeta data. This is important when you have registered an external node that is not using a Consul agent via the /v1/catalog/register API that include NodeMeta. Once restoring the snapshot the node is visible but it's MetaData is gone.

I have also seen similar behavior when all servers have been restarted the NodeMeta would not persist in the data directory, even though on closer inspection it appears to be in the raft.db file.

[mkeeler]

@nickmy9729 Thanks for the report.

I think the problem is around here in the code:

consul/agent/consul/fsm/snapshot_oss.go

Lines 74 to 79 in e305443

	req := structs.RegisterRequest{
	Node: n.Node,
	Address: n.Address,
	TaggedAddresses: n.TaggedAddresses,
	}

I ran into a similar issue recently where we weren't putting some of the data into the snapshot and restoring it out of a snapshot properly. That is when its in raft too. So the situation sounds pretty similar.

[shubheksha]

I'll pick this up!

[nickmy9729]

I just submitted a PR that seems to fix this issue #4527