Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-discover, add k8s auto-join #4635

Merged
merged 3 commits into from
Sep 6, 2018
Merged

Update go-discover, add k8s auto-join #4635

merged 3 commits into from
Sep 6, 2018

Conversation

mitchellh
Copy link
Contributor

This updates go-discover to add k8s auto-join.

The docs will come in a separate PR since I want to get the helm chart docs out there first.

This PR:

  • Updates go-discover to include k8s provider
  • Adds k8s client library to the vendor folder. This is all additive and doesn't risk other dependencies.

@mitchellh mitchellh requested review from kyhavlov and banks September 5, 2018 20:50
banks
banks approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. I checked the vendor.json changes and they seem good.

@mitchellh
Copy link
Contributor Author

aye aye, should be pretty minor. Awesome. Merging it in.

@mitchellh mitchellh merged commit 12e58dd into master Sep 6, 2018
@mitchellh mitchellh deleted the f-discover-k8s branch September 6, 2018 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banks banks banks approved these changes

@kyhavlov kyhavlov Awaiting requested review from kyhavlov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchellh @banks