Add start-wan-join, retry-wan-join and related configuration and commandline options #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and commandline options
|
Looking great! As a huge nitpick, could you please rename the StartWanJoin => StartJoinWan for all the different names / variables? I think RetryMaxWan reads better than RetryWanMax. Similarly for the CLI flags, "-retry-max-wan" looks better than "-retry-wan-max". This way all the variables / flags are the same but suffixed with WAN. Thanks! |
|
Sure - I debated both :) |
|
LGTM! Thanks! |
armon
added a commit
that referenced
this pull request
Nov 18, 2014
Add start-wan-join, retry-wan-join and related configuration and commandline options
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
Change annotationInject to keyInjectStatus since it's used as an annotation as well as a label.
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
…icorp#477)" This reverts commit 39863701f9b983e17799b898a49916b5cfb3689c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.