Make the 'consul version' to return value that is from 'git describe --tags' #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thanks! |
armon
added a commit
that referenced
this pull request
Nov 19, 2014
Make the 'consul version' to return value that is from 'git describe --tags'
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
Add component label to all services
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
remove podpending processing from health checks in the endpoints controller as podpending pods are not part of endpoints objects so we'd never reconcile this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the changes below the consul I self compiled shows