Documentation and changes for verify_server_hostname
#5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
approved these changes
Dec 6, 2018
pearkes
added a commit
that referenced
this pull request
Dec 6, 2018
* verify_server_hostname implies verify_outgoing * mention CVE in the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Consul 0.5.1, our documentation and parts of our implementation have stated that setting
verify_server_hostnametotruewould implicitly configureverify_outgoingto true. A bug in this implementation resulted in this being partially incorrect and resulting in plaintext communication in agent-to-agent RPC.All affected users can add the verify_outgoing key (set to
true) to their configuration and restart all Consul agents - both client and server. We recommend checking the validity of the TLS certificates since the issue may have been masking expired or invalid certificates, as they were not being used.This corrects the documentation we will make live now, as well as the fix that will go into Consul 1.4.1.
Note that this is assigned CVE-2018-19653 and we will be posting separately on the Consul mailing list to notify users with more detailed instructions and information.
Mailing List Announcement Post