Adding merge delegate to prevent mixing clusters #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armon
added a commit
that referenced
this pull request
Jan 6, 2015
Adding merge delegate to prevent mixing clusters
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
…leted (hashicorp#580) Endpoints controller may have stale cache for pod objects since it's only watching the endpoints objects. As a result when we try to get a pod from cache, it may be stale. For the case of deleting ACL tokens, we can't tolerate stale cache reads since we need to know for sure if the pod exists to determine if an ACL token for that pod should be deleted. This commit changes it to instead use the pod info stored in the endpoints addresses as TargetRef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new Serf MergeDelegate support, Consul can prevent a join that would cause cluster merges to take place. On the LAN ring we ensure all the other nodes match our datacenter, and on the WAN ring all other nodes must be a server. This should solve most of the accidental join issues. It does not solve the problem of a client joining the WAN ring IF there is only a single datacenter, but does fix most other conditions. Fixes #260