Adding Semaphore support to API #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I read through this code a bit earlier, it all LGTM! 👍 |
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
Helm chart values and template changes: * Add a new Helm value global.openshift.enabled * Add a SecurityContextConstraint for the consul clients when global.openshift.enabled is set to true * Don't set fsGroup for the servers when global.openshift.enabled is set to true * Remove server.disableFsGroupSecurityContext value and fail in the chart if someone tries to set it * Increase memory limits and requests from 25Mi to 50Mi for all jobs and service-init containers in the terminating and ingress gateway deployments. This was mostly determined by running the tests. There are other containers that still have the 25Mi memory request and limit, however those containers were not causing failures on OpenShift. Acceptance tests changes: * Add a new flag -enable-openshift to the framework which will set global.openshift.enabled to true for all helm installs/upgrades. * Increase timeouts in various places because it takes longer for things to be created on OpenShift. * Change consul-dns test to retry and to not use TTY since it's not always available. CI changes: * Add a new job to run acceptance tests against OpenShift. Note that it currently runs against pre-created Azure Red Hat OpenShift clusters. I was not able to get terraform running to create them before each run due to a variety of reasons, the main one being that it takes a not yet determined amount of time for the clusters to become ready. It has been hard to determine that time in a script/CI, which resulted in intermittent/non-deterministic test failures. We will have to address further automation of the OpenShift cluster creation at a later time. * Add a new workflow to run acceptance tests nightly. * Add Azure CLI and OpenShift CLI to the Docker image used in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Semaphore implementation to the API. Similar to Lock, however the Semaphore can be used to allow multiple slots which is useful for worker pools and other situations with shared access with some upper limit.