Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase size of documented gossip encryption key size #6244

Closed
freddygv opened this issue Jul 30, 2019 · 6 comments
Closed

Increase size of documented gossip encryption key size #6244

freddygv opened this issue Jul 30, 2019 · 6 comments
Assignees
Labels
type/docs Documentation needs to be created/updated/clarified type/enhancement Proposed improvement or new feature

Comments

@freddygv
Copy link
Contributor

freddygv commented Jul 30, 2019

Currently Consul's docs state that gossip encryption keys must be 16 bytes long. However, the underlying memberlist library, allows for 16, 24, and 32 byte keys (supporting AES 128, 192, and 256).

Consul should move the default key size to 32 bytes so that gossiped messages are encrypted with AES 256. This would be an improvement for users who expect or require AES 256 to encrypt their data.

Currently AES 256 is supported for gossip encryption, but it's not documented. This proposal is to change the default in the key generator as well as the related documentation and tests.

Lastly, Consul would continue to allow 16-byte gossip encryption keys. These would no longer be generated by the keygen command.

@freddygv freddygv added type/enhancement Proposed improvement or new feature type/docs Documentation needs to be created/updated/clarified labels Jul 30, 2019
@freddygv freddygv self-assigned this Jul 30, 2019
@freddygv
Copy link
Contributor Author

freddygv commented Aug 8, 2019

Will be in upcoming release, closing.

@freddygv freddygv closed this as completed Aug 8, 2019
@kmcquade
Copy link

@freddygv - There is no referenced PR here. Where was this added?

@freddygv
Copy link
Contributor Author

@kmcquade I'm having trouble finding the PR, but here's the commit:
1a14b94

@blake
Copy link
Member

blake commented Jan 17, 2020

I was able to locate this in #6388. That commit SHA doesn't seem to be present in any PRs other than this one.

@kmcquade
Copy link

Thanks everyone. I really appreciate it. I’m sure this will help others who are wondering the same thing in the future.

@ghost
Copy link

ghost commented Jan 25, 2020

Hey there,

This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days.

If you are still experiencing problems, or still have questions, feel free to open a new one 👍.

@ghost ghost locked and limited conversation to collaborators Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/docs Documentation needs to be created/updated/clarified type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests

3 participants