-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connect: expose an API endpoint to compile the discovery chain #6248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I have a couple of thoughts for minor changes.
It also needs docs - I'd like to see what the output looks like in practice as it's a little hard to imagine just from the structs being used but I guess we'd see that in docs.
Also API package equivalents are also important not to forget before we land and close the issue.
5b246f0
to
f66c962
Compare
7bddbec
to
247756e
Compare
f66c962
to
a8e1888
Compare
* removed some unnecessary compiler output * remove configurability of OverprovisioningFactor
72a55eb
to
534a9f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just a few really minor requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #6213
Fixes #6255
DiscoveryTarget
to be TextMarshalled/v1/discovery-chain/<service>
: GET lets you pass the evaluationDC as an URL parameter but nothing else more complex. Anything else goes over POST (like overrides)