Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: default the primary_datacenter to the datacenter if not configured #7111

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Jan 22, 2020

Something similar already happens inside of the server
(agent/consul/server.go) but by doing it in the general config parsing
for the agent we can have agent-level code rely on the PrimaryDatacenter
field, too.

…ured

Something similar already happens inside of the server
(agent/consul/server.go) but by doing it in the general config parsing
for the agent we can have agent-level code rely on the PrimaryDatacenter
field, too.
@rboyer rboyer requested a review from a team January 22, 2020 22:32
@rboyer rboyer self-assigned this Jan 22, 2020
@rboyer rboyer mentioned this pull request Jan 22, 2020
9 tasks
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rboyer rboyer merged commit 0f44bcd into master Jan 23, 2020
@rboyer rboyer deleted the default-primary-dc-in-config branch January 23, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants