Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering support to the v1/connect/intentions endpoint #7478

Closed
mkeeler opened this issue Mar 23, 2020 · 0 comments · Fixed by #7593
Closed

Add filtering support to the v1/connect/intentions endpoint #7478

mkeeler opened this issue Mar 23, 2020 · 0 comments · Fixed by #7593
Assignees
Labels
type/enhancement Proposed improvement or new feature
Milestone

Comments

@mkeeler
Copy link
Member

mkeeler commented Mar 23, 2020

Some of our APIs can accept a filter to limit which results from a listing operation get returned. That is generally documented here.

This feature request is to enable this filtering for the v1/connect/intentions endpoint. The HTTP API should already be parsing the filtering parameters and storing them in the QueryOptions field on the DCSpecificRequest struct. So I think the only work here will be:

  • Modify the Intention.List RPC endpoint to enable filtering and add some tests
  • Update structs_filtering_test.go with a test for test to assert the filterable fields do not change without us knowing it.
  • Update the docs for the HTTP endpoint with the list of filterable fields.
@mkeeler mkeeler added the type/enhancement Proposed improvement or new feature label Mar 23, 2020
@mkeeler mkeeler added this to the 1.8.0 milestone Mar 23, 2020
@mkeeler mkeeler self-assigned this Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Proposed improvement or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant