Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acl: add DisplayName field to auth methods #7769

Merged
merged 3 commits into from
May 4, 2020
Merged

acl: add DisplayName field to auth methods #7769

merged 3 commits into from
May 4, 2020

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented May 4, 2020

Also add a few missing acl fields in the api.

@rboyer
acl: add DisplayName field to auth methods
b450e87 
Also add a few missing acl fields in the api.
@rboyer rboyer added the theme/acls ACL and token generation label May 4, 2020
@rboyer rboyer added this to the 1.8.0 milestone May 4, 2020
@rboyer rboyer requested a review from a team May 4, 2020 15:14
@rboyer rboyer self-assigned this May 4, 2020
schristoff
schristoff approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, I just had one clarification question.
:) 🤙

@rboyer rboyer requested a review from schristoff May 4, 2020 18:10
@rboyer rboyer merged commit ca52ba7 into master May 4, 2020
@rboyer rboyer deleted the auth-method-display-names branch May 4, 2020 20:18
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff schristoff approved these changes

Assignees

@rboyer rboyer

Labels
theme/acls ACL and token generation
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rboyer @schristoff