Support different advertise address for WAN gossip #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Managed to add some integration tests, please tell me if I should add anything else! |
added 5 commits
March 28, 2015 16:08
…Addr values in b than in a
|
@armon would you mind please checking this to let us know whether we are on the right track or not? |
|
@pepov Sorry about the epic delay! Not sure how this slipped through. This looks great, merging! |
armon
added a commit
that referenced
this pull request
May 4, 2015
Support different advertise address for WAN gossip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt on #527