Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Fix service splitter returning service weight or a zero #8355

Merged
merged 1 commit into from
Jul 21, 2020
Merged

ui: Fix service splitter returning service weight or a zero #8355

merged 1 commit into from
Jul 21, 2020

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented Jul 21, 2020

No description provided.

@kaxcode kaxcode added the theme/ui Anything related to the UI label Jul 21, 2020
@kaxcode kaxcode requested a review from alvin-huang July 21, 2020 21:55
alvin-huang
alvin-huang approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@alvin-huang alvin-huang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

You'll want to also add a changelog entry in the changelog on the release/1.7.x branch

@kaxcode kaxcode merged commit dd8240f into release/1.7.x Jul 21, 2020
@kaxcode kaxcode deleted the ui/bug/service-splitters-weight-zero branch July 21, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-huang alvin-huang alvin-huang approved these changes

Assignees
No one assigned
Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaxcode @alvin-huang @mikemorris