Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

☂️ Use metrics labels for metadata rather than appending metadata to the metric name #8420

Closed
mkcp opened this issue Jul 22, 2020 · 3 comments
Closed

☂️ Use metrics labels for metadata rather than appending metadata to the metric name #8420

mkcp opened this issue Jul 22, 2020 · 3 comments
Labels
theme/telemetry Anything related to telemetry or observability type/umbrella-☂️ Makes issue the "source of truth" for multiple requests relating to the same topic
Milestone
1.9.0

Comments

@mkcp
Copy link
Contributor

mkcp commented Jul 22, 2020 •
edited
Loading

We underutilize labels in Consul right now because go-metrics predates their use. Most timeseries storage and rendering systems are optimized to handle fewer metric names with more dimensions in their labels.

Any change where we're converting suffixes to labels will be breaking. Therefore we'll need to support both the current behavior and the new behavior for at least one release. This gives users a chance to convert over without having to pre-set-up their dashboards, reducing the friction of upgrading.

A mechanism inside of Consul for managing backwards compatibility with these metrics is being discussed in: #8421
@mkcp mkcp changed the title Umbrella: Ensure labels are used properly ☂️ Ensure labels are used properly Jul 22, 2020
@mkcp
Copy link
Contributor Author

mkcp commented Jul 22, 2020 •
edited
Loading

Related:
Pull #8271
#4611

Raft suffixes
#4450
Addressed by hashicorp/raft#409

@mkcp mkcp changed the title ☂️ Ensure labels are used properly ☂️ Use metrics labels for metadata rather than appending metadata to the metric name Jul 30, 2020
@mkcp mkcp transferred this issue from hashicorp/consul-foundations-metrics-1.9 Jul 30, 2020
@mkcp mkcp added theme/telemetry Anything related to telemetry or observability type/umbrella-☂️ Makes issue the "source of truth" for multiple requests relating to the same topic labels Jul 30, 2020
@mkcp mkcp added this to the 1.9 milestone Aug 18, 2020
@mkcp
Copy link
Contributor Author

mkcp commented Oct 5, 2020

This is solved by #8271 and hashicorp/raft#409

@mkcp
Copy link
Contributor Author

mkcp commented Oct 8, 2020

Resolved in 1.9

@mkcp mkcp closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme/telemetry Anything related to telemetry or observability type/umbrella-☂️ Makes issue the "source of truth" for multiple requests relating to the same topic
Projects
None yet
Milestone
1.9.0
Development

No branches or pull requests
1 participant
@mkcp