Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use service datacenter for dns name #8704

Merged
merged 2 commits into from
Sep 22, 2020
Merged

use service datacenter for dns name #8704

merged 2 commits into from
Sep 22, 2020

Conversation

hanshasselberg
Copy link
Member

I am pretty sure this was an oversight, it should be the service datacenter here. I did not check for the other places, but will be.

@dnephin dnephin requested a review from a team September 18, 2020 15:55
@crhino
Copy link
Contributor

crhino commented Sep 21, 2020

Ah ok, I see the issue here. The problem is that we are using the UI node's own configured datacenter to construct the DNS name, rather than the datacenter the ingress service is actually in.

Since the structs.GatewayService does not currently save the datacenter in which the service is registered, we probably want to use the args.Datacenter value of the request struct to get the correct value.

mkeeler
mkeeler approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like the change @crhino requested has already been done.

crhino
crhino approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@crhino crhino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, LGTM. Checked the TestAgent_RegisterServiceDeregisterService_Sidecar failure locally, and it passed when I ran it.

@hanshasselberg hanshasselberg merged commit a89ee1a into master Sep 22, 2020
@hanshasselberg hanshasselberg deleted the fix_dns_name_for_gateways branch September 22, 2020 18:34
@hashicorp-ci
Copy link
Contributor

🍒❌ Cherry pick of commit a89ee1a onto release/1.8.x failed! Build Log

@crhino crhino mentioned this pull request Sep 23, 2020
Merged
3 tasks
rboyer pushed a commit that referenced this pull request Sep 25, 2020
@hanshasselberg @rboyer
use service datacenter for dns name (#8704)
010abda 
* Use args.Datacenter instead of configured datacenter
@rboyer rboyer mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeeler mkeeler mkeeler approved these changes

@crhino crhino crhino approved these changes

@freddygv freddygv Awaiting requested review from freddygv

@kyhavlov kyhavlov Awaiting requested review from kyhavlov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hanshasselberg @crhino @hashicorp-ci @mkeeler @hashibot-web