-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability for the v1/connect/ca/roots endpoint to return a PEM encoded certificate chain #8774
Conversation
fd48049
to
d455c34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d455c34
to
5361701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some minor things.
…ncoded certificate chain
f7d5dd3
to
84baae4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one more typo.
Co-authored-by: R.B. Boyer <rb@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍒✅ Cherry pick of commit 8f890bc onto |
…ncoded certificate chain (#8774) Co-authored-by: R.B. Boyer <rb@hashicorp.com>
The
v1/connect/ca/roots
endpoint has picked up apem=true
argument. When set this causes the endpoint to output data with aContent-Type
set toapplication/pem-certificate-chain
and the response body to be a PEM encoded certificate chain of all root and intermediate certs that would normally be contained in the response.This output format can be useful in situations where you need a certificate bundle for passing off to another application such as the Consul CLI when they will interact with an API presenting behind a Connect CA signed TLS cert (such as when
auto_encrypt
orauto_config
are used for generating a Consul clients HTTPs certificate).