-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Add deny SVG lines with icons #8846
ui: Add deny SVG lines with icons #8846
Conversation
7ef5217
to
816c3a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking super good! 👏
I noticed we need to make sure the icons change position when the data changes also (so blocking queries basically) - guessing we can probably do similar to what we originally did to get the lines updating for blocking queries?
I left a couple more non-important inline comments seeing, if you feel like changing those while you are in there then great, no prob if not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I spotted a couple of non-important typos you may wanna fix up whilst you are waiting on backend support
7edf81d
to
6e63964
Compare
Use Cases:
New contextual components: