Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Add deny SVG lines with icons #8846

Merged
merged 12 commits into from
Oct 8, 2020
Merged

ui: Add deny SVG lines with icons #8846

merged 12 commits into from
Oct 8, 2020

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented Oct 6, 2020

Use Cases:

  1. If intention is set to deny between services, the SVG lines is red with an icon.
  2. If intention is set with L7, the line remains gray but has a L7 icon.

New contextual components:

  • TopologyMetrics::Icon
  • TopologyMetrics::UpLines
  • TopologyMetrics::DownLines

Screen Shot 2020-10-06 at 7 25 53 PM

@kaxcode kaxcode added the theme/ui Anything related to the UI label Oct 6, 2020
@kaxcode kaxcode requested a review from johncowen October 6, 2020 23:30
@kaxcode kaxcode force-pushed the ui/feature/add-lines-and-buttons-to-SVG-lines branch from 7ef5217 to 816c3a1 Compare October 6, 2020 23:35
@kaxcode kaxcode added this to the 1.9 milestone Oct 6, 2020
johncowen
johncowen reviewed Oct 7, 2020
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking super good! 👏

I noticed we need to make sure the icons change position when the data changes also (so blocking queries basically) - guessing we can probably do similar to what we originally did to get the lines updating for blocking queries?

I left a couple more non-important inline comments seeing, if you feel like changing those while you are in there then great, no prob if not.

ui-v2/app/components/topology-metrics/index.js Outdated Show resolved Hide resolved
ui-v2/app/components/topology-metrics/index.js Outdated Show resolved Hide resolved
ui-v2/app/components/topology-metrics/index.js Show resolved Hide resolved
ui-v2/app/components/topology-metrics/index.js Outdated Show resolved Hide resolved
@kaxcode kaxcode requested a review from johncowen October 7, 2020 13:36
johncowen
johncowen approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I spotted a couple of non-important typos you may wanna fix up whilst you are waiting on backend support

ui-v2/app/components/topology-metrics/down-lines/index.js Outdated Show resolved Hide resolved
ui-v2/app/components/topology-metrics/up-lines/index.js Show resolved Hide resolved
@kaxcode kaxcode force-pushed the ui/feature/add-lines-and-buttons-to-SVG-lines branch from 7edf81d to 6e63964 Compare October 8, 2020 15:40
@kaxcode kaxcode merged commit b373456 into master Oct 8, 2020
@kaxcode kaxcode deleted the ui/feature/add-lines-and-buttons-to-SVG-lines branch October 8, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncowen johncowen johncowen approved these changes

Assignees
No one assigned
Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kaxcode @johncowen @hashibot-web