-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update to Go 1.15.4 and alpine:3.12 #9036
Conversation
In the go-test-api |
It looks like maybe static validation of time is more strict in 1.15, not sure if this simply means two of these failing tests could be removed now...
|
@mikemorris I fixed the two tests in question. The error messages are mostly the same, except that now the inputs are wrapped in double quotes now so our assertions were slightly incorrect. |
Now there's this fun one with multiple occurrences:
|
might be good to wait until |
I also regenerated some of the TLS test data files so they don't anger the updated tls stack in Go. |
Yeaaaa, |
Sooo, clock skew is potentially not fun, and we just published a I'm slightly unclear on if the issue is only present when running a compiled binary on an affected version of alpine or if the issue is which version of alpine was used to compile the binary, but it looks like 1.8.5 could be affected... /cc @alvin-huang |
Service mesh doesn't use the Common Name, preferring instead the newer SubjectAlternativeName (SAN) field. The former is singly valued and the latter is multi valued. |
This lets you easily display the common name and subject alternative name fields from the CLI:
|
f573a75
to
a1828f6
Compare
Go 1.15 drops support for 32-bit binaries on Darwin https://golang.org/doc/go1.15#darwin
…1.15, this value is always true
a1828f6
to
4a3d1a7
Compare
🍒 Starting backport cherry picking. To cherry-pick post-merge, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/280920. |
🍒✅ Cherry pick of commit 7af643a onto |
* ci: stop building darwin/386 binaries Go 1.15 drops support for 32-bit binaries on Darwin https://golang.org/doc/go1.15#darwin * tls: ConnectionState::NegotiatedProtocolIsMutual is deprecated in Go 1.15, this value is always true * correct error messages that changed slightly * Completely regenerate some TLS test data Co-authored-by: R.B. Boyer <rb@hashicorp.com>
Is there any substantial reason we can't/shouldn't bump to Go 1.15.x for the Consul 1.9 release series? Did I miss bumping the version in any files?