-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add minimal configtest command #904
Conversation
helpText := ` | ||
Usage: consul configtest [options] | ||
|
||
Test that configs are valid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a more verbose description? It would be helpful to explain what exactly the command does and why it is useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How's this sound?
Tests that configs are valid by attempting to parse them. Useful to ensure a configuration change will not cause consul to fail after a restart.
@josephholsten this looks much better, thanks! RE: command naming, I think |
I'll squash commits once we're ready. |
@ryanuber care to review the code again? I'll get the middleman doc ready |
8cc0775
to
3e6f40e
Compare
Should be fully tested, doc'd, squashed and ready to roll. |
|
||
# Consul ConfigTest | ||
|
||
The `consul configtest` command is the heart of Consul: it runs the agent that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description needs some updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha! updated.
3e6f40e
to
afbf688
Compare
This LGTM. Thanks! |
add minimal configtest command
Minimalist implementation of #901. Needs:
Open questions:
consul configtest
or some other color of bike shed? This is similar toapachectl configtest
.