Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acl: global tokens created by auth methods now correctly replicate to secondary datacenters #9351

Merged
merged 3 commits into from
Dec 9, 2020

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Dec 8, 2020

Previously the tokens would fail to insert into the secondary's state
store because the AuthMethod field of the ACLToken did not point to a
known auth method from the primary.

…e to secondary datacenters

Previously the tokens would fail to insert into the secondary's state
store because the AuthMethod field of the ACLToken did not point to a
known auth method from the primary.
@rboyer rboyer added type/bug Feature does not function as expected backport/1.8 labels Dec 8, 2020
@rboyer rboyer requested review from mkeeler and a team December 8, 2020 22:26
@rboyer rboyer self-assigned this Dec 8, 2020
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.

Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failure seems like it could be legit.

@rboyer rboyer changed the title acl: global tokens created by auth methods can not correctly replicate to secondary datacenters acl: global tokens created by auth methods now correctly replicate to secondary datacenters Dec 9, 2020
@rboyer rboyer merged commit d921690 into master Dec 9, 2020
@rboyer rboyer deleted the fix-auth-method-global-locality-token-replication branch December 9, 2020 21:22
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/295014.

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit d921690 onto release/1.9.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Dec 9, 2020
… secondary datacenters (#9351)

Previously the tokens would fail to insert into the secondary's state
store because the AuthMethod field of the ACLToken did not point to a
known auth method from the primary.
@hashicorp-ci
Copy link
Contributor

🍒❌ Cherry pick of commit d921690 onto release/1.8.x failed! Build Log

rboyer added a commit that referenced this pull request Dec 9, 2020
… secondary datacenters

Previously the tokens would fail to insert into the secondary's state
store because the AuthMethod field of the ACLToken did not point to a
known auth method from the primary.

Backport of #9351 to 1.8.x
rboyer added a commit that referenced this pull request Dec 10, 2020
… secondary datacenters (#9363)

Previously the tokens would fail to insert into the secondary's state
store because the AuthMethod field of the ACLToken did not point to a
known auth method from the primary.

Backport of #9351 to 1.8.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Feature does not function as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants