Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Accessibility scan improvements #9485

Merged
merged 10 commits into from
Jan 5, 2021
Merged

ui: Accessibility scan improvements #9485

merged 10 commits into from
Jan 5, 2021

Conversation

johncowen
Copy link
Contributor

This PR adds various accessibility scanning fixes:

  1. Remove the old tab related roles now that the tabs are navigational rather than tabs.
  2. Ensure we have unique ID's in the topology component.
  3. h3 > h2 switching - we are moving to a place where h* tags are only used in top level page templates, and hence their order is completely configurable per page.

@github-actions github-actions bot added the theme/ui Anything related to the UI label Jan 4, 2021
@johncowen johncowen marked this pull request as ready for review January 4, 2021 17:12
@johncowen johncowen requested a review from kaxcode January 4, 2021 17:12
kaxcode
kaxcode approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice 🔥

@johncowen johncowen merged commit 1743802 into master Jan 5, 2021
@johncowen johncowen deleted the ui/bugfix/remove-tabpanel-role branch January 5, 2021 10:06
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/303926.

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 1743802 onto release/1.9.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Jan 5, 2021
@johncowen @hashicorp-ci
ui: Accessibility scan improvements (#9485)
d15cbc9 
* ui: Remove all vestiges of role=tabpanel

* Switch out tablist role for a label, default to Secondary

* Move healthcheckout-output headers to h2, ideally these would be outside the component

* Add aria-label for empty button

* Fix up non-unique ids in topology component

* Temporarily fixup h2 in KV > LockSession

* Fixup dl with no dt

* h3 > h2

* Fix up page objects that were reliant on ids
@johncowen johncowen mentioned this pull request Jan 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaxcode kaxcode kaxcode approved these changes

@nathancoleman nathancoleman Awaiting requested review from nathancoleman

Assignees

@nathancoleman nathancoleman

Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johncowen @hashicorp-ci @kaxcode @nathancoleman