ui: Make sure we pass the nspace through to the API for nodes #9488
Conversation
|
@mikemorris , just checking in to make sure this is how you'd want to do this? I did this completely manually and copied over the same change log (with this PRs number) Thinking if I label as backport to 1.7 from here it should go cleanly from 1.8 to 1.7 |
|
LGTM for backport targeting 1.8.x!
I believe the backport label flow only triggers on PRs targeting |
|
Thanks!
Ah cool I did wonder, I can just manually cherry pick if not 👍 |
Nodes themselves are not namespaced, so we'd originally assumed we did not need to pass through the ns query parameter when listing or viewing nodes. As it turns out the API endpoints we use to list and view nodes (and related things) return things that are namespaced, therefore any API requests for nodes do require a the ns query parameter to be passed through to the request. This PR adds the necessary ns query param to all things Node, apart from the querying for the leader which only returns node related information.
…#9499) Nodes themselves are not namespaced, so we'd originally assumed we did not need to pass through the ns query parameter when listing or viewing nodes. As it turns out the API endpoints we use to list and view nodes (and related things) return things that are namespaced, therefore any API requests for nodes do require a the ns query parameter to be passed through to the request. This PR adds the necessary ns query param to all things Node, apart from the querying for the leader which only returns node related information.
Manual backport of #9410 to 1.8.x