Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: enable query options on agent endpoints #9903

Merged
merged 1 commit into from
Mar 19, 2021
Merged

api: enable query options on agent endpoints #9903

merged 1 commit into from
Mar 19, 2021

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Mar 18, 2021

This PR adds support for setting QueryOptions on a few Agent API
endpoints. Nomad needs to be able to set the Namespace field on
these endpoints to:

  • query for services / checks in a namespace
  • deregister services / checks in a namespace
  • update TTL status on checks in a namespace

@github-actions github-actions bot added the theme/api Relating to the HTTP API interface label Mar 18, 2021
@shoenig
Copy link
Member Author

shoenig commented Mar 18, 2021

I'm not sure of where to edit the changelog, https://github.com/hashicorp/consul/blob/master/CHANGELOG.md seems really out of date. The test-integrations failure looks like some docker auth error.

@shoenig shoenig marked this pull request as ready for review March 18, 2021 19:20
dnephin
dnephin approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! LGTM with a changelog entry. The changelog entry can be added by adding the file .changelog/9903.txt, see #8387 for some examples

@shoenig
api: enable query options on agent endpoints
cd1cd4f 
This PR adds support for setting QueryOptions on a few agent API
endpoints. Nomad needs to be able to set the Namespace field on
these endpoints to:
 - query for services / checks in a namespace
 - deregister services / checks in a namespace
 - update TTL status on checks in a namespace
@vercel vercel bot temporarily deployed to Preview – consul March 19, 2021 18:08 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging March 19, 2021 18:08 Inactive
@dnephin dnephin merged commit 0b0ec7f into master Mar 19, 2021
@dnephin dnephin deleted the f-agent-qopts branch March 19, 2021 18:52
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/340960.

blake added a commit that referenced this pull request Jul 24, 2021
@blake
api: enable query opts on agent health and maintenance endpoints
3da2a42 
This PR adds support for setting QueryOptions on the following agent
API endpoints:

- /agent/health/service/name/:name
- /agent/health/service/id/:id
- /agent/service/maintenance/:id

This follows the same pattern used in #9903 to support query options
for other agent API endpoints.

Resolves #9710
This was referenced Jul 24, 2021
Merged
Closed
blake added a commit that referenced this pull request Jul 30, 2021
@blake
api: Support QueryOptions on additional agent endpoints (#10691)
c919f2d 
Add support for setting QueryOptions on the following agent API endpoints:

- /agent/health/service/name/:name
- /agent/health/service/id/:id
- /agent/service/maintenance/:id

This follows the same pattern used in #9903 to support query options
for other agent API endpoints.

Resolves #9710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees
No one assigned
Labels
theme/api Relating to the HTTP API interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoenig @hashicorp-ci @dnephin