Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform aws rhel6 enhancement #992

Merged
merged 7 commits into from
Jun 2, 2015
Merged

Terraform aws rhel6 enhancement #992

merged 7 commits into from
Jun 2, 2015

Conversation

sathiyas
Copy link
Contributor

@sathiyas sathiyas commented Jun 1, 2015

Enhanced the aws templates for consul set up to add rhel6. Made ubuntu as default so that no changes are needed for execution if ubuntu is needed. In future will submit PRs for rhel7 and centos versions. rhel7 has new way of doing upstarts, hence need to separate rhel6 and rhel7 implementations.

description = "The instance type to launch."
default = {
ubuntu = "m1.small"
rhel6 = "m3.medium"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a different default instance type for RHEL? Seems like we should just make them the same.

@phinze
Copy link
Contributor

phinze commented Jun 2, 2015

One question, otherwise this is looking good!

@sathiyas
Copy link
Contributor Author

sathiyas commented Jun 2, 2015

@phinze, thanks for asking, I should have mentioned it, RHEL AMIs are HVM based and do not take m1 instances.

@phinze
Copy link
Contributor

phinze commented Jun 2, 2015

@sathiyas ah okay - can you go t2.micro instead then? we want to keep the defaults in the examples relatively cheap 😀

Ideally we can switch the ubuntu AMIs to HVM as well just to keep it simpler.

@phinze phinze closed this Jun 2, 2015
@phinze phinze reopened this Jun 2, 2015
@phinze
Copy link
Contributor

phinze commented Jun 2, 2015

(Sorry accidentally hit the wrong button there)

@sathiyas
Copy link
Contributor Author

sathiyas commented Jun 2, 2015

Sure, let me update with both Ubuntu/RHEL6 HVM AMIs with t2.micro

@sathiyas
Copy link
Contributor Author

sathiyas commented Jun 2, 2015

@phinze , thanks for quick review, I made changes to reflect latest AMIs for HVM for both ubuntu and rhel6 and tested both.

@phinze
Copy link
Contributor

phinze commented Jun 2, 2015

Re-kicked the deploy - some ephemeral failures there. LGTM!

phinze added a commit that referenced this pull request Jun 2, 2015
@phinze phinze merged commit 0ed0883 into hashicorp:master Jun 2, 2015
duckhan pushed a commit to duckhan/consul that referenced this pull request Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants