-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform aws rhel6 enhancement #992
Terraform aws rhel6 enhancement #992
Conversation
description = "The instance type to launch." | ||
default = { | ||
ubuntu = "m1.small" | ||
rhel6 = "m3.medium" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a different default instance type for RHEL? Seems like we should just make them the same.
One question, otherwise this is looking good! |
@phinze, thanks for asking, I should have mentioned it, RHEL AMIs are HVM based and do not take m1 instances. |
@sathiyas ah okay - can you go t2.micro instead then? we want to keep the defaults in the examples relatively cheap 😀 Ideally we can switch the ubuntu AMIs to HVM as well just to keep it simpler. |
(Sorry accidentally hit the wrong button there) |
Sure, let me update with both Ubuntu/RHEL6 HVM AMIs with t2.micro |
@phinze , thanks for quick review, I made changes to reflect latest AMIs for HVM for both ubuntu and rhel6 and tested both. |
Re-kicked the deploy - some ephemeral failures there. LGTM! |
…ement Terraform aws rhel6 enhancement
Enhanced the aws templates for consul set up to add rhel6. Made ubuntu as default so that no changes are needed for execution if ubuntu is needed. In future will submit PRs for rhel7 and centos versions. rhel7 has new way of doing upstarts, hence need to separate rhel6 and rhel7 implementations.