Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in v1.7.2 - Existing GIT_SSH_COMMAND env variables are unset. #452

Closed
aliscott opened this issue Sep 6, 2023 · 1 comment · May be fixed by #453
Closed

Regression in v1.7.2 - Existing GIT_SSH_COMMAND env variables are unset. #452

aliscott opened this issue Sep 6, 2023 · 1 comment · May be fixed by #453
Labels

Comments

@aliscott
Copy link

aliscott commented Sep 6, 2023

It looks like v1.7.2 caused a regression. #300 caused a regression that unsets an existing GIT_SSH_COMMAND env variable if it is set.

Problem

If I have GIT_SSH_COMMAND="ssh -o 'StrictHostKeyChecking=no'" and no sshKey query param set, go-getter is not passing the StrictHostKeyChecking=no option when downloading the repo.

Expected

From what I understand from #299 we want to leave the GIT_SSH_COMMAND untouched when an sshKey param is not set.

Although #300 fixed the case so GIT_SSH_COMMAND isn't set to GIT_SSH_COMMAND=ssh when a sshKey param is not used, it also unset it if it had an existing value. I think if GIT_SSH_COMMAND is already set in the environment then it should be left unchanged.

@jbardin
Copy link
Member

jbardin commented Oct 10, 2023

Closed via #459

@jbardin jbardin closed this as completed Oct 10, 2023
@crw crw added the bug label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants