-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decoder: Finish reference collection implementation for Constraint
#228
Comments
This was referenced Mar 20, 2023
radeksimko
changed the title
decoder: Verify reference collection implementation for
decoder: Finish reference collection implementation for Mar 22, 2023
Constraint
Constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
For the following constraints:
Set
asConstraint
#194List
asConstraint
#195Tuple
asConstraint
#198Map
asConstraint
#199Object
asConstraint
#203we have implemented reference collection to our best effort/knowledge, but were unable to test most of that logic due to inability to use other "collectable" constraints, such as
LiteralValue
asConstraint
#187LiteralType
asConstraint
#186Reference
asConstraint
#185This is therefore a reminder to come back to all constraints and ensure that the implementation is indeed correct and tested properly.
Proposal
List
- add testsList
- collect parent target for the whole listList
- add testsSet
- add testsSet
- collect parent target for the whole setSet
- add testsTuple
- add testsTuple
- collect parent target for the whole tupleTuple
- add testsMap
- add testsMap
- add testsObject
- add testsObject
- add testsLiteralType
- add testsLiteralValue
- add testsThe text was updated successfully, but these errors were encountered: