Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoder: Finish reference collection implementation for Constraint #228

Closed
15 tasks
radeksimko opened this issue Mar 13, 2023 · 0 comments · Fixed by #239
Closed
15 tasks

decoder: Finish reference collection implementation for Constraint #228

radeksimko opened this issue Mar 13, 2023 · 0 comments · Fixed by #239

Comments

@radeksimko
Copy link
Member

radeksimko commented Mar 13, 2023

Context

For the following constraints:

we have implemented reference collection to our best effort/knowledge, but were unable to test most of that logic due to inability to use other "collectable" constraints, such as

This is therefore a reminder to come back to all constraints and ensure that the implementation is indeed correct and tested properly.

Proposal

  • reference origins: List - add tests
  • reference targets: List - collect parent target for the whole list
  • reference targets: List - add tests
  • reference origins: Set - add tests
  • reference targets: Set - collect parent target for the whole set
  • reference targets: Set - add tests
  • reference origins: Tuple - add tests
  • reference targets: Tuple - collect parent target for the whole tuple
  • reference targets: Tuple - add tests
  • reference origins: Map - add tests
  • reference targets: Map - add tests
  • reference origins: Object - add tests
  • reference targets: Object - add tests
  • reference targets: LiteralType - add tests
  • reference targets: LiteralValue - add tests
@radeksimko radeksimko changed the title decoder: Verify reference collection implementation for Constraint decoder: Finish reference collection implementation for Constraint Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant