-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: add parameterized dispatch interface #10675
Conversation
This commit adds a new interface for dispatching parameteried jobs, if the user has the right permissions. The UI can be accessed by viewing a parameterized job and clicking on the "Dispatch Job" button located in the "Job Launches" section.
Is that failing test something that I can address? I don't know what is meant by |
Wow, thanks @nicholascioli! Just a heads up that it might take us a little bit to get to reviewing this one as we're in the middle of bringing on new UI folks who will want to have a say here. I think the "resource not available by integration" is a GitHub Actions auth issue... it looks like that specific test needs a GitHub token but we don't want to expose those to PRs from the community. So don't worry about that for now. |
This commit cleans up a few things that had typos and inconsistent naming. In line with this, the custom `meta` view was removed in favor of using the included `AttributesTable`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this wonderful feature PR @nicholascioli!
I flagged some issues that we found while reviewing, but most are small style changes. The main blockers is the lack of bas64
encoding of the payload and the use of originalTarget
, which causes the form to fail on non-Firefox browsers.
You don't have to worry about making any of these changes, @JBhagat841 and I will work on them, but if you feel like tackling some of them before we do feel free to go ahead 😄
Thank you again for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will take another look in the afternoon after we chat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes #9313
This commit adds a new interface for dispatching parameteried jobs, if
the user has the right permissions. The UI can be accessed by viewing a
parameterized job and clicking on the "Dispatch Job" button located in
the "Job Launches" section.
(Note: This commit adds one dependency
title-case
for pretty printing ofmeta names. This can be removed if necessary.)
Given the following configuration:
The following screenshots show the generated interface.