Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: refactor operator debug capture #11466

Merged
merged 7 commits into from
Nov 5, 2021
Merged

Conversation

davemay99
Copy link
Contributor

This PR refactors the collection routines for Consul and Vault, captures a bit more useful information for troubleshooting, and expands the unit test coverage.

  • Fix Consul/Vault TLS address mismatch issues
  • Fix Vault sys health URL
  • Add capture of Consul agent host and agent metrics
  • Add CLI version to output
  • Update unit test to validate multiregion cluster

@davemay99
Copy link
Contributor Author

Note that additional refactoring will be coming later for Vault (had to pick a stopping point).

Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first pass on the refactoring! Looking forward to the next pass.

client/testutil/driver_compatible.go Show resolved Hide resolved
@davemay99 davemay99 merged commit 6ede4b9 into main Nov 5, 2021
@davemay99 davemay99 deleted the b-debug-refactor-external branch November 5, 2021 23:43
@davemay99 davemay99 added this to the 1.2.0 milestone Nov 5, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants