-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Concurrent Download Support for artifacts #11531
Add Concurrent Download Support for artifacts #11531
Conversation
@lgfa29 @schmichael - can you please take a look and let me know if there are any changes needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but there should be a test for the case where there are 4 artifacts and the first one fails to download as currently I believe that leaks a goroutine.
A https://pkg.go.dev/net/http/httptest test server should allow testing against an artifact server where you can control the error rate.
hey sorry folks, got caught up with other work, i'll try to get this closed by this weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I pushed a changelog entry. Mind cleaning up the tests a bit more?
I'd like to hold off merging this to main
until we do one more 1.2.x release. I'll label it so it doesn't get lost.
To be fair, this did work. It didn't get lost! However I did almost forget to merge it for 1.3.0! 😬 Merging now and will be released in 1.3.0-rc1! Thanks @gowthamgts |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR adds support for concurrent downloads as requested on #11244. Currently 3 is set as the max number of downloads that can be active at a time, but I'm happy to add that to client or task configuration.
resolves #11244