Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log level parsing from lines that include a timestamp #11838

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Fix log level parsing from lines that include a timestamp #11838

merged 3 commits into from
Jan 13, 2022

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Jan 13, 2022

Update go-hclog to pull hashicorp/go-hclog#101 and fix log level inference from dependencies that don't use go-hclog.

Closes #11594

@vercel vercel bot temporarily deployed to Preview – nomad January 13, 2022 01:51 Inactive
@lgfa29 lgfa29 added this to the 1.2.4 milestone Jan 13, 2022
@lgfa29 lgfa29 requested review from jrasell and tgross January 13, 2022 01:52
@vercel vercel bot temporarily deployed to Preview – nomad January 13, 2022 02:09 Inactive
jrasell
jrasell approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tgross
tgross approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgfa29 lgfa29 merged commit 3bf78fd into main Jan 13, 2022
@lgfa29 lgfa29 deleted the gh-11594 branch January 13, 2022 14:56
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrasell jrasell jrasell approved these changes

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.4
Development

Successfully merging this pull request may close these issues.

Nomad 1.2.x template stanza logs ConsulKV entries and data field
3 participants
@lgfa29 @tgross @jrasell