-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix health checking for ephemeral poststart tasks #11945
Conversation
baadfda
to
5da5985
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @beautifulentropy!
This will ship in the next major release (1.3.0) and get backported to 1.2.x and 1.1.x. Thanks again! |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR updates the logic in the Nomad client's alloc health tracker which
erroneously marks existing healthy allocations with dead poststart ephemeral
tasks as unhealthy even if they were already successful during a previous
deployment. For repro see: #10058 (comment)
Currently, users are having to insert sleep after short-lived ephemeral tasks.
This change ensures that poststart lifecycle tasks which have succeeded,
even before 'min_healthy_time', will not result in the whole allocation being
marked as unhealthy.
I've attempted to include test coverage that sticks to your existing conventions.
which have already succeeded with any running duration.
Fixes #9254
Fixes #10058